Fix critical GC <> LSP bug and enable dynamic GC configuration. #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
added
bug
JoshuaBatty
force-pushed
the
josh/storage_gc_test
branch
from
ec3ace2
to
cb52d85
Compare
Benchmark for 5c0bdbdClick to view benchmark
|
JoshuaBatty
force-pushed
the
josh/storage_gc_test
branch
from
0312862
to
088014f
Compare
Benchmark for 423c3bfClick to view benchmark
|
Benchmark for 1cf00d4Click to view benchmark
|
JoshuaBatty
force-pushed
the
josh/storage_gc_test
branch
from
5c576c2
to
768c2ab
Compare
Benchmark for 71ce3abClick to view benchmark
|
JoshuaBatty
changed the title
Merged
xunilrj
reviewed
Apr 5, 2024
|
Nice work, really glad to see this and that you have been able to the bottom of these issues 👍 |
Benchmark for 79368d2Click to view benchmark
|
JoshuaBatty
force-pushed
the
josh/storage_gc_test
branch
from
0cc01ab
to
694ef82
Compare
Benchmark for 0270bb2Click to view benchmark
|
JoshuaBatty
force-pushed
the
josh/storage_gc_test
branch
from
7e7f8e1
to
bfa26a9
Compare
sdankel
previously approved these changes
Apr 11, 2024
tritao
reviewed
Apr 11, 2024
Benchmark for 182bdfcClick to view benchmark
|
xunilrj
approved these changes
Apr 11, 2024
tritao
approved these changes
Apr 11, 2024
IGI-111
added a commit
that referenced
this pull request
Apr 11, 2024
## Description Bump repo to 0.53.0 waiting on #5813 Co-authored-by: IGI-111 <[email protected]>
8 tasks
JoshuaBatty
added a commit
that referenced
this pull request
Apr 18, 2024
## Description Fixes a critical bug where the server would crash if compilation was triggered from anything other than the root `main.sw` file. This was due to the metrics_map using the `SourceId` rather then the `ModuleId` as the key. This was introduced last week in #5813 as we now need to metrics to decide if the engines should be mem swapped or discarded. closes #5870 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The newThis test now passes.garbage_collection_storagetest doesn't pass yet. See #5814 to track progress on fixing this bug.Ok this all works, feeling pretty confident that we've got to the bottom of this bug. The GC and LSP should be pretty robust now. Turned out to be 3 things that were causing the transient bugs.
We are now also able to wrap the QE types in Arcs which is saving about ~23ms in cloning on each keystroke.
closes #5814
closes #5550
Checklist
Breaking*orNew Featurelabels where relevant.