-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New encoding fixes #5745
Merged
Merged
New encoding fixes #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 55eac41Click to view benchmark
|
Benchmark for 8a622c7Click to view benchmark
|
Benchmark for 088e4e1Click to view benchmark
|
Benchmark for 3d5a10bClick to view benchmark
|
IGI-111
approved these changes
Mar 20, 2024
JoshuaBatty
approved these changes
Mar 20, 2024
Benchmark for 0b768a0Click to view benchmark
|
…this was a quick fix to an already fixed problem); guarantee new encoding flag in all contexts; play safe with fn call cache for autogenerated code
xunilrj
force-pushed
the
xunilrj/new-encoding-fixes
branch
from
March 20, 2024 07:34
21cc7a1
to
8f3b3b7
Compare
Benchmark for 290e9e8Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains three fixes:
1 - Fix to partial monomorphization. The fix was just removing a "quick-fix" that was merged and it is not needed anymore after #5684;
2 - To play safe,
compile_fn_call
cache will not be used for autogenerated code;3 -
experimental-new-encoding
was not being copied in all cases.Two other small changes are:
1 -
Buffer
struct does not offer a genericpush
anymore, because this function was extremely deceiving for primitive datatypes which have memory layouts very different from the encoding memory layout (u16, u32 etc...);2 - Changing name of one test to make the test more obvious and easier to run just one specific test.
Checklist
Breaking*
orNew Feature
labels where relevant.