Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TraitItem::TraitFn to be stored in the parsed declaration engine. #5714

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Mar 9, 2024

Description

This PR ports TraitItem::TraitFn to be stored in the parsed declaration engine, thus allowing it to be referenced as a parsed declaration id, which will be required by a future AST ordering pass.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Mar 9, 2024
@tritao tritao requested review from JoshuaBatty, IGI-111 and a team March 9, 2024 19:25
@tritao tritao self-assigned this Mar 9, 2024
@tritao tritao marked this pull request as ready for review March 10, 2024 14:22
@tritao tritao enabled auto-merge (squash) March 10, 2024 14:22
@tritao tritao merged commit c18797f into FuelLabs:master Mar 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants