Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an explicit module id when generating auto impl declarations #5712

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Use an explicit module id when generating auto impl declarations #5712

merged 6 commits into from
Mar 11, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Mar 8, 2024

Description

This PR makes sure we assign specific module ids to the generated auto impl decls.

Helps with #5698.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged language server LSP server compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Mar 8, 2024
@tritao tritao self-assigned this Mar 8, 2024
@tritao tritao requested a review from a team March 9, 2024 13:55
@tritao tritao enabled auto-merge (squash) March 9, 2024 13:55
@tritao tritao requested review from a team, esdrubal and IGI-111 March 11, 2024 09:41
@tritao tritao merged commit 0583480 into FuelLabs:master Mar 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@xunilrj xunilrj xunilrj approved these changes

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

@esdrubal esdrubal Awaiting requested review from esdrubal

Assignees

@tritao tritao

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tritao @xunilrj @IGI-111