Enable LSP Garbage Collection test for CI #5704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 6248fd0Click to view benchmark
|
Benchmark for c737ffcClick to view benchmark
|
Benchmark for 284a9c6Click to view benchmark
|
IGI-111
previously approved these changes
Mar 7, 2024
7 tasks
xunilrj
previously approved these changes
Mar 7, 2024
kayagokalp
previously approved these changes
Mar 7, 2024
Benchmark for 8415a17Click to view benchmark
|
sdankel
previously approved these changes
Mar 7, 2024
kayagokalp
dismissed stale reviews from sdankel and themself
The base branch was changed.
IGI-111
approved these changes
Mar 8, 2024
Benchmark for bc518e1Click to view benchmark
|
kayagokalp
approved these changes
Mar 8, 2024
crodas
approved these changes
Mar 8, 2024
This was referenced Mar 13, 2024
JoshuaBatty
added a commit
that referenced
this pull request
Mar 14, 2024
## Description Removes comments added in #5704. The change setting None cases to true is actually correct and what we want. @danielbate
JoshuaBatty
added a commit
that referenced
this pull request
Mar 14, 2024
## Description This test was originally added in #5704. The initial ambition of compiling 400 times, aimed at rigorously evaluating the garbage collector's resilience, inadvertently led to stack overflows and adverse interactions when executed alongside concurrent tests. To address these issues while preserving the test's core objectives, the following modifications have been made: Compilation Frequency Reduction: The iteration count for compilations has been adjusted from 400 to 60. This change significantly accelerates test completion without compromising the test's ability to effectively assess garbage collector performance and stability. Runtime Isolation: Transitioning from #[tokio::test] to a standard #[test] annotation, we now initiate a dedicated Tokio runtime within the test. This approach prevents the test from sharing the runtime environment with other tests, thereby eliminating concurrent execution and its associated complexities. --------- Co-authored-by: Sophie Dankel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables a did_change stress test with random wait times between each trigger to emulate random key typing. This then internally kicks off compilation and triggers garbage collection every 3 keystrokes.
I had intended to include this test when garbage collection was implemented in #5251. However, at that time, we were only performing GC every 10th keystroke and it was overloading the stack in CI. Now that we have reduced this to every 3rd keystroke it seems to be fine for CI.
Unfortunately, this test wasn't running to catch a bug that slipped through in #5306. As such, this PR currently allows a way for us to reproduce this error but won't be able to pass CI until the underlying issue is resolved.
P.S.: This also adds a temporary fix where we retain elements without a source id. This is tantamount to leaking them but seems preferable to disabling the GC altogether.