Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scoped namespace accesses and clones in type check context #5642

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Feb 21, 2024

Description

So this is another incremental step towards a following PR with the initial collection context migration.

Refactor namespace access in type check context.
Remove clones from scoped namespace usage.
Simplify type-check context creation from a namespace.

No functional changes intended.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Feb 21, 2024
@tritao tritao requested a review from a team February 21, 2024 16:21
@tritao tritao self-assigned this Feb 21, 2024
@tritao tritao force-pushed the typecheck-namespace-refactor branch 4 times, most recently from d1d100e to e8eca9f Compare February 21, 2024 19:36
@tritao tritao force-pushed the typecheck-namespace-refactor branch from e8eca9f to 7ece874 Compare February 22, 2024 08:54
@tritao tritao force-pushed the typecheck-namespace-refactor branch from 7ece874 to 4cd714a Compare February 22, 2024 08:55
@IGI-111 IGI-111 requested a review from a team February 22, 2024 16:40
@tritao tritao enabled auto-merge (squash) February 22, 2024 21:36
@tritao tritao merged commit 5073919 into FuelLabs:master Feb 23, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants