Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained generational-arena with slotmap #5629

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Replace unmaintained generational-arena with slotmap #5629

merged 2 commits into from
Feb 19, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Feb 19, 2024

Description

Fixes #5628

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added code quality compiler: ir IRgen and sway-ir including optimization passes labels Feb 19, 2024
@IGI-111 IGI-111 self-assigned this Feb 19, 2024
@IGI-111 IGI-111 added the breaking May cause existing user code to break. Requires a minor or major release. label Feb 19, 2024
@IGI-111 IGI-111 force-pushed the IGI-111/slotmap branch 4 times, most recently from bf07649 to 64e98ff Compare February 19, 2024 06:09
@IGI-111 IGI-111 marked this pull request as ready for review February 19, 2024 08:20
@IGI-111 IGI-111 requested a review from a team February 19, 2024 08:20
@IGI-111 IGI-111 merged commit 08b102d into master Feb 19, 2024
34 checks passed
@IGI-111 IGI-111 deleted the IGI-111/slotmap branch February 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaivaswatha vaivaswatha vaivaswatha approved these changes

@tritao tritao tritao approved these changes

Assignees

@IGI-111 IGI-111

Labels
breaking May cause existing user code to break. Requires a minor or major release. code quality compiler: ir IRgen and sway-ir including optimization passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0014: generational-arena is unmaintained
3 participants
@IGI-111 @tritao @vaivaswatha