Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce deterministic order in hashmaps #5584

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Enforce deterministic order in hashmaps #5584

merged 1 commit into from
Feb 9, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Feb 8, 2024

Description

This PR does three things:

  1. use Rust 1.76.0
  2. enable the new iter_over_hash_type Clippy lint on relevant crates
  3. use indexmap::IndexMap to replace any equivalent HashMap being iterated upon with a deterministically ordered alternative

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 requested a review from a team February 8, 2024 22:33
@IGI-111 IGI-111 self-assigned this Feb 8, 2024
@IGI-111 IGI-111 requested a review from a team February 8, 2024 22:34
@IGI-111 IGI-111 force-pushed the IGI-111/indexmap_and_lint branch 5 times, most recently from ddc3a53 to d19f074 Compare February 9, 2024 00:43
@IGI-111 IGI-111 added the breaking May cause existing user code to break. Requires a minor or major release. label Feb 9, 2024
@IGI-111 IGI-111 force-pushed the IGI-111/indexmap_and_lint branch 3 times, most recently from f33d168 to fd3bdac Compare February 9, 2024 03:24
@IGI-111 IGI-111 marked this pull request as ready for review February 9, 2024 03:52
@IGI-111 IGI-111 force-pushed the IGI-111/indexmap_and_lint branch 2 times, most recently from ed85d2d to 7c8709e Compare February 9, 2024 04:37
@IGI-111
Enforce deterministic order in hashmaps
0bbf3a0 
This PR does three things:

1. use Rust 1.76.0
2. enable the new `iter_over_hash_type` Clippy lint on relevant crates
3. use `indexmap::IndexMap` to replace any equivalent `HashMap` being iterated upon with a deterministically ordered alternative
@xunilrj xunilrj merged commit 71025c8 into master Feb 9, 2024
34 checks passed
@xunilrj xunilrj deleted the IGI-111/indexmap_and_lint branch February 9, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esdrubal esdrubal esdrubal approved these changes

@xunilrj xunilrj xunilrj approved these changes

Assignees

@IGI-111 IGI-111

Labels
breaking May cause existing user code to break. Requires a minor or major release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGI-111 @xunilrj @esdrubal