Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing shadowing errors due to error deduplication #5532

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fix missing shadowing errors due to error deduplication #5532

merged 3 commits into from
Jan 31, 2024

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Jan 31, 2024

Description

Fixes #5502.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Jan 31, 2024
@ironcev ironcev requested review from a team January 31, 2024 11:19
@ironcev ironcev self-assigned this Jan 31, 2024
@ironcev ironcev enabled auto-merge (squash) January 31, 2024 15:03
@ironcev ironcev merged commit 1fee545 into master Jan 31, 2024
34 checks passed
@ironcev ironcev deleted the ironcev/5502-missing-error-messages-in-shadowing-errors branch January 31, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritao tritao tritao approved these changes

@xunilrj xunilrj xunilrj approved these changes

Assignees

@ironcev ironcev

Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing error messages in shadowing errors
3 participants
@ironcev @xunilrj @tritao