LSP Optimization: Wrap programs_cache in an Arc
#5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
added
language server
12 tasks
ironcev
previously approved these changes
Jan 16, 2024
|
Looks good, just wondering if we should wrap |
Good idea, added in fe93ba1 |
ironcev
approved these changes
Jan 17, 2024
tritao
approved these changes
Jan 17, 2024
JoshuaBatty
added a commit
that referenced
this pull request
Feb 5, 2024
## Description This was added as an optimization in #5472. However, it seems to be the cause of a transient bug that is causing the language server to crash outlined in #5531. We should revert this optimization until we understand how to avoid this crash from happening. cc @tritao ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We clone the
Enginesbefore each keystroke in the language server. We shouldn't need to clone anything other than a pointer for theprograms_cache. Measured against thebenchmarkexample insway-lsptests, this saves us23.015ms.related to #5445
Checklist
Breaking*orNew Featurelabels where relevant.