Fixes error while using From trait that returns a tuple. #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
force-pushed
the
esdrubal/5299_from_returning_tuple
branch
4 times, most recently
from
99d9837
to
8eb448f
Compare
esdrubal
force-pushed
the
esdrubal/5299_from_returning_tuple
branch
from
8eb448f
to
832d179
Compare
Instead of `Trait "MyFrom<u256>" is not implemented for type "U".` We now get `Trait "MyFrom<u256>" is not implemented for type "(_, _, _, _)".` The error is followed by: `Cannot infer type for type parameter "_". Insufficient type information provided. Try annotating its type.` While Rust compiler is able to inference the type in this situation it is non trivial to do it properly hence we should probably keep asking for the type to be annotated.
IGI-111
approved these changes
Jan 23, 2024
JoshuaBatty
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of
Trait "MyFrom<u256>" is not implemented for type "U".We now getTrait "MyFrom<u256>" is not implemented for type "(_, _, _, _)".The error is followed by:
Cannot infer type for type parameter "_". Insufficient type information provided. Try annotating its type.While Rust compiler is able to inference the type in this situation it is non trivial to do it properly hence for now we should probably keep asking for the type to be annotated and create an issue for it.
Checklist
Breaking*orNew Featurelabels where relevant.