Create the asset_id.sw
file and move AssetId
out of contract_id.sw
#5439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
AssetId
type from thecontract_id.sw
file and into the newasset_id.sw
file for better composability and navigation of the standard library.This PR causes breaking changes as the
transfer()
andmint_to()
functions fromAddress
,ContractId
, andIdentity
have been removed due to circular dependencies. This was originally added in this PR to give developers a familiarity from solidity. It has been heavily debated whether this should be kept in the standard library as it adds complexity and duplicates the existingtransfer()
andmint_to()
functions. For the sake of simplicity and ensuring likeness between all asset management functions, especially in audits, this has been removed.Checklist
Breaking*
orNew Feature
labels where relevant.