Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve forc-fmt to format std lib and core #5410

Merged
merged 15 commits into from
Dec 21, 2023
Merged

Improve forc-fmt to format std lib and core #5410

merged 15 commits into from
Dec 21, 2023

Conversation

crodas
Copy link
Contributor

@crodas crodas commented Dec 19, 2023 •
edited
Loading

Description

Changes needed to build #5404 and #5405

Improvements

  1. Use byte-offset instead of chars offset
  2. Enhanced asm formatting

Better output when tests fail

image

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@crodas crodas self-assigned this Dec 19, 2023
@crodas crodas mentioned this pull request Dec 19, 2023
Merged
7 tasks
@crodas crodas changed the title Fix wrong new line with UTF-8 bytes Improve forc-fmt to format std lib and core Dec 19, 2023
crodas added a commit that referenced this pull request Dec 19, 2023
@crodas
Run forc-fmt with #5410
69d5a1f
crodas added a commit that referenced this pull request Dec 19, 2023
@crodas
Run forc-fmt with #5410
33f9c35
crodas added a commit that referenced this pull request Dec 19, 2023
@crodas
Run forc-fmt with #5410
013562a
crodas added a commit that referenced this pull request Dec 19, 2023
@crodas
Run forc-fmt with #5410
29be50b
crodas added a commit that referenced this pull request Dec 19, 2023
@crodas
Run forc-fmt with #5410
06f4738
crodas added a commit that referenced this pull request Dec 21, 2023
@crodas
Run forc-fmt with #5410
41dc0c5
crodas added a commit that referenced this pull request Dec 21, 2023
@crodas
Run forc-fmt with #5410
6dbf8d3
@crodas crodas requested a review from a team December 21, 2023 05:23
@crodas crodas marked this pull request as ready for review December 21, 2023 05:23
@crodas crodas enabled auto-merge (squash) December 21, 2023 05:24
kayagokalp
kayagokalp previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, left a nit

swayfmt/tests/mod.rs Outdated Show resolved Hide resolved
@kayagokalp kayagokalp requested a review from a team December 21, 2023 08:42
@kayagokalp kayagokalp added lib: std Standard library formatter lib: core Core library labels Dec 21, 2023
kayagokalp
kayagokalp previously approved these changes Dec 21, 2023
View reviewed changes
@kayagokalp kayagokalp requested a review from a team December 21, 2023 18:56
Cesar Rodas and others added 7 commits December 21, 2023 17:55
@crodas
Fix wrong new line with UTF-8 bytes
a80d42d 
Most codes work fine with byte-offsets instead of char offsets (not
always one char offset is equal to one byte offset). Non ascii character
usually appears inside strings and comments and it was messing up the
offsets from that point forward
@crodas
Improve asm formatting and enhanced error message for tests
dcba497
@crodas
forc-fmt on examples
2f460ef
@crodas
Add more tests
e301c49
@crodas
Add support for comments in between attributes in annotated objects
8328e90
@crodas
Single tuples should and parens should be inline be inline
0431c5f
@crodas
Improve multiple lines of of statements
4397e1c
@crodas crodas force-pushed the fmt-improvements-std-lib-core branch from 4550c29 to 7ab743e Compare December 21, 2023 21:32
crodas added a commit that referenced this pull request Dec 21, 2023
@crodas
Run forc-fmt with #5410
0523d02
crodas added a commit that referenced this pull request Dec 21, 2023
@crodas
Run forc-fmt with #5410
2118c9a
@crodas crodas requested review from a team, sdankel and kayagokalp December 21, 2023 21:33
crodas added a commit that referenced this pull request Dec 21, 2023
@crodas
Run forc-fmt with #5410
8089596
sdankel
sdankel previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@crodas crodas force-pushed the fmt-improvements-std-lib-core branch from 2bd20f1 to edf58e9 Compare December 21, 2023 23:17
JoshuaBatty
JoshuaBatty previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@crodas crodas merged commit d353371 into master Dec 21, 2023
29 checks passed
@crodas crodas deleted the fmt-improvements-std-lib-core branch December 21, 2023 23:57
This was referenced Dec 30, 2023
Closed
Closed
@JoshuaBatty JoshuaBatty mentioned this pull request Jan 4, 2024
Closed
7 tasks
@crodas crodas mentioned this pull request Jan 4, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@crodas crodas

Labels
formatter lib: core Core library lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crodas @JoshuaBatty @kayagokalp @sdankel