Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor forc-test to expose VM interpreter #5409

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Refactor forc-test to expose VM interpreter #5409

merged 10 commits into from
Dec 20, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Dec 19, 2023 •
edited
Loading

Description

Related #2350

This refactor is not intended to change any behavior. It adds TestExecutor which has a handle to vm::Interpreter. This will be used to access the debugger within the VM.

Also moved the "setup" related code into a new file to make the code more organized.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review December 19, 2023 04:48
@sdankel sdankel requested review from kayagokalp and a team December 19, 2023 04:48
@JoshuaBatty JoshuaBatty added the forc-test Everything related to the `forc-test` lib and `forc test` command. label Dec 19, 2023
JoshuaBatty
JoshuaBatty approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@JoshuaBatty JoshuaBatty requested a review from a team December 19, 2023 23:06
@sdankel sdankel enabled auto-merge (squash) December 20, 2023 01:09
@sdankel sdankel merged commit d3da28d into master Dec 20, 2023
33 checks passed
@sdankel sdankel deleted the sophie/refactorTestExec branch December 20, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@crodas crodas crodas approved these changes

@kayagokalp kayagokalp Awaiting requested review from kayagokalp

Assignees

@sdankel sdankel

Labels
forc-test Everything related to the `forc-test` lib and `forc test` command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdankel @crodas @JoshuaBatty