Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Language Server I/O to Use Tokio Async Primitives #5378

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

JoshuaBatty
Copy link
Member

Description

Aligned the language server's I/O operations with the tower-lsp async framework by adopting Tokio's asynchronous I/O primitives instead of ones from std::fs.

Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JoshuaBatty JoshuaBatty requested a review from a team December 12, 2023 22:05
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) December 12, 2023 22:06
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@JoshuaBatty JoshuaBatty merged commit d95e313 into master Dec 12, 2023
29 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/async_io branch December 12, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants