Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused monomorphization code. #5266

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Nov 10, 2023

Description

This removes monomorphization code that was added previously by Emily, but never got finished and is thus unused currently.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this Nov 10, 2023
@tritao tritao marked this pull request as ready for review November 13, 2023 14:58
@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen code quality labels Nov 13, 2023
@tritao tritao requested a review from a team November 13, 2023 14:58
@IGI-111 IGI-111 requested a review from a team November 13, 2023 15:30
@ironcev
Copy link
Member

ironcev commented Nov 13, 2023

@tritao Well, if you have had removed this code a few days before it would save me pondering about it and adapting it to support references 😄

@tritao tritao merged commit ea0624b into FuelLabs:master Nov 13, 2023
32 checks passed
esdrubal pushed a commit that referenced this pull request Nov 15, 2023
## Description

This removes monomorphization code that was added previously by Emily,
but never got finished and is thus unused currently.

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants