Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not memcpy optimize when passed as fn arg #5253

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Do not memcpy optimize when passed as fn arg #5253

merged 5 commits into from
Nov 2, 2023

Conversation

vaivaswatha
Copy link
Contributor

This fixes a bug in local_copy_prop_prememcpy which didn't make an exception when a local gets passed its address into another function, thus making it unsafe to optimize it.

Closes #5250
Related to #4600

@vaivaswatha
Do not memcpy optimize when passed as fn arg
a13bbb8 
This fixes a bug in `local_copy_prop_prememcpy` which didn't
make an exception when a local gets passed its address into
another function, thus making it unsafe to optimize it.

Closes #5250
Related to #4600
@vaivaswatha vaivaswatha self-assigned this Nov 2, 2023
@vaivaswatha vaivaswatha requested a review from a team November 2, 2023 06:03
ironcev
ironcev approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@ironcev ironcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix. There was no disabling memcpy when passing to asm before and now it's the same for function calls.

@vaivaswatha vaivaswatha enabled auto-merge (squash) November 2, 2023 08:58
@vaivaswatha vaivaswatha merged commit ae31213 into master Nov 2, 2023
32 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/memcpy_bug_5250 branch November 2, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcev ironcev ironcev approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@vaivaswatha vaivaswatha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass-by-value semantics not preserved when using __addr_of
3 participants
@vaivaswatha @JoshuaBatty @ironcev