Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unexpected trait dummy method error. #5234

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Fixes unexpected trait dummy method error. #5234

merged 5 commits into from
Oct 30, 2023

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Oct 27, 2023 •
edited
Loading

Description

The unexpected trait dummy method error is now replaced by: Trait "MyTrait" is not implemented for type "u64". This is the intended behavior and now throws the equivalent of rust error.

This commit also adds some improvements to the DebugWithEngines.

Closes #5201

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal self-assigned this Oct 27, 2023
@esdrubal esdrubal force-pushed the esdrubal/5201_unexpected_trait_dummy_method branch from 8aff2e4 to 3bfba2b Compare October 27, 2023 10:00
@esdrubal
Fixes unexpected trait dummy method error.
3bfba2b 
The unexpected trait dummy method error is now replaced by:
`Trait "MyTrait" is not implemented for type "u64".`
This is the intended behavior and now throws the equivalent of rust error.

This commit also adds some improvements to the `DebugWithEngines`.

Closes #5201
@esdrubal esdrubal requested a review from a team October 27, 2023 11:01
@esdrubal esdrubal marked this pull request as ready for review October 27, 2023 11:21
@esdrubal esdrubal added bug Something isn't working P: critical Should be looked at before anything else compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Oct 27, 2023
tritao
tritao previously approved these changes Oct 27, 2023
View reviewed changes
ironcev
ironcev previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@ironcev ironcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one supertiny typo otherwise 👍

sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs Outdated Show resolved Hide resolved
@esdrubal esdrubal dismissed stale reviews from ironcev and tritao via 4c5c26b October 30, 2023 14:31
@tritao tritao merged commit aee7926 into master Oct 30, 2023
32 checks passed
@tritao tritao deleted the esdrubal/5201_unexpected_trait_dummy_method branch October 30, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@ironcev ironcev ironcev approved these changes

@tritao tritao Awaiting requested review from tritao

Assignees

@esdrubal esdrubal

Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: critical Should be looked at before anything else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal compiler error: Method foo_6 is a trait method dummy and was not properly replaced.
4 participants
@esdrubal @tritao @ironcev @IGI-111