-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes missing error on type unification. #5230
Conversation
7d9ce80
to
77dd59c
Compare
If we're going to have multiple modes like this, it might be a good idea to refactor the unifier to work like |
The |
Added test showing that #5162 is resolved with the changes proposed in this PR. |
181acad
to
cdfeefd
Compare
While using generic blanket implementation no error was thrown when another type other than the generic blanket expected type was used. This was caused by the typechecker being too permissive in UnknownGeneric unification. The fix changes the unifier to handle unification with the expected self and generics as special cases. Closes #5212
Description
While using generic blanket implementation no error was thrown when another type other than the generic blanket expected type was used.
This was caused by the typechecker being too permissive in UnknownGeneric unification. The fix changes the unifier to handle unification with the expected self and generics as special cases.
Closes #5212
Closes #5162
Checklist
Breaking*
orNew Feature
labels where relevant.