Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid bidirectional flow control characters in literals #5146

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Forbid bidirectional flow control characters in literals #5146

merged 2 commits into from
Sep 26, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Sep 26, 2023

Description

Forbid directional formatting characters from
UAX #9 in literals to fix #5047.
This is similar to rustc's text_direction_codepoint_in_literal lint. Such characters are already implicitly forbidden in other parts of the syntax.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added bug Something isn't working breaking May cause existing user code to break. Requires a minor or major release. compiler: parser Everything to do with the parser labels Sep 26, 2023
@IGI-111 IGI-111 requested a review from a team September 26, 2023 08:55
@IGI-111 IGI-111 self-assigned this Sep 26, 2023
tritao
tritao previously approved these changes Sep 26, 2023
View reviewed changes
@IGI-111
Forbid bidirectional flow control characters in literals
0f6e776 
Forbid directional formatting characters from
[UAX #9](https://www.unicode.org/reports/tr9/#Directional_Formatting_Characters)
in literals to fix #5047.
This is similar to rustc's `text_direction_codepoint_in_literal` lint.
Such characters are already implicitly forbidden in other parts of the syntax.
@IGI-111 IGI-111 requested a review from a team September 26, 2023 11:24
@IGI-111 IGI-111 enabled auto-merge (squash) September 26, 2023 11:24
@IGI-111 IGI-111 merged commit fc9b6aa into master Sep 26, 2023
31 checks passed
@IGI-111 IGI-111 deleted the IGI-111/forbid_bidi branch September 26, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@tritao tritao tritao approved these changes

Assignees

@IGI-111 IGI-111

Labels
breaking May cause existing user code to break. Requires a minor or major release. bug Something isn't working compiler: parser Everything to do with the parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOB-FUEL-25: Invisible code points are supported in Sway programs
3 participants
@IGI-111 @tritao @JoshuaBatty