Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: link to docs hub fuel installation guide #5144

Merged
merged 6 commits into from
Oct 12, 2023
Merged

docs: link to docs hub fuel installation guide #5144

merged 6 commits into from
Oct 12, 2023

Conversation

cold-briu
Copy link
Contributor

Description

In order to remove documentation redundancy issues, the fuel installation guide is being centralized in the docs-hub.
Check docs-hub/62

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • [] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@cold-briu cold-briu mentioned this pull request Sep 25, 2023
Merged
@sarahschwartz sarahschwartz marked this pull request as draft September 26, 2023 16:20
@cold-briu cold-briu marked this pull request as ready for review October 5, 2023 23:00
@cold-briu cold-briu marked this pull request as draft October 7, 2023 02:52
sarahschwartz
sarahschwartz reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sarahschwartz sarahschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should combine the installation and quickstart pages into one "getting started" page since they are both so short now.

docs/book/src/introduction/installation.md Outdated Show resolved Hide resolved
@cold-briu cold-briu marked this pull request as ready for review October 9, 2023 17:38
sarahschwartz
sarahschwartz approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@sarahschwartz sarahschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cold-briu cold-briu requested review from bitzoic and calldelegation and removed request for bitzoic October 11, 2023 15:32
@cold-briu cold-briu enabled auto-merge (squash) October 12, 2023 04:37
@cold-briu cold-briu merged commit 98d0810 into master Oct 12, 2023
29 checks passed
@cold-briu cold-briu deleted the docs/fuelup-install-guide branch October 12, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calldelegation calldelegation calldelegation approved these changes

@sarahschwartz sarahschwartz sarahschwartz approved these changes

Assignees

@cold-briu cold-briu

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cold-briu @sarahschwartz @calldelegation