Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating documentation for u256 #5111

Merged
merged 6 commits into from
Sep 21, 2023
Merged

updating documentation for u256 #5111

merged 6 commits into from
Sep 21, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 12, 2023 •
edited
Loading

Description

This PR is part of #4794 and updates documentation for u256 and improves test for edge cases.

Code also prints more info when tests run in verbose mode.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj marked this pull request as ready for review September 13, 2023 08:15
@xunilrj xunilrj requested a review from a team September 13, 2023 08:15
anton-trunov
anton-trunov previously approved these changes Sep 13, 2023
View reviewed changes
docs/book/src/reference/solidity_differences.md Outdated Show resolved Hide resolved
@IGI-111 IGI-111 requested a review from a team September 13, 2023 11:53
@xunilrj xunilrj mentioned this pull request Sep 13, 2023
Closed
19 tasks
@anton-trunov anton-trunov merged commit ce0627e into master Sep 21, 2023
31 checks passed
@anton-trunov anton-trunov deleted the xunilrj/u256-docs branch September 21, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@anton-trunov anton-trunov anton-trunov approved these changes

@tritao tritao tritao approved these changes

@IGI-111 IGI-111 Awaiting requested review from IGI-111

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xunilrj @tritao @anton-trunov @IGI-111 @sdankel