Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust existing Diagnostic API according to the Expressive Diagnostics RFC #5100

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Adjust existing Diagnostic API according to the Expressive Diagnostics RFC #5100

merged 7 commits into from
Sep 11, 2023

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Sep 8, 2023

Description

This PR implements the decisions made in the Expressive Diagnostics RFC and adapts the existing diagnostics:

  • Issue is removed from the header and placed in code.
  • Help can also be in code.
  • Wording is simplified.

Closes #5075.

Demo (Before and After)

Match arm is unreachable - Variant 1

Match arm is unreachable - Variant 2

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev requested review from a team September 8, 2023 12:34
@ironcev ironcev self-assigned this Sep 8, 2023
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Sep 8, 2023
xunilrj
xunilrj reviewed Sep 8, 2023
View reviewed changes
forc-util/src/lib.rs Outdated Show resolved Hide resolved
xunilrj
xunilrj previously approved these changes Sep 8, 2023
View reviewed changes
@ironcev ironcev requested a review from xunilrj September 8, 2023 20:31
@ironcev ironcev mentioned this pull request Sep 10, 2023
Merged
7 tasks
@ironcev ironcev merged commit c3f3a36 into master Sep 11, 2023
31 checks passed
@ironcev ironcev deleted the ironcev/5075-adjust-existing-diagnostic-API branch September 11, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@xunilrj xunilrj xunilrj approved these changes

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

Assignees

@ironcev ironcev

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust existing Diagnostic API according to the Expressive Diagnostics RFC
4 participants
@ironcev @xunilrj @anton-trunov @IGI-111