Implement Hash
trait for Bytes
and String
types
#5089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
Hasher
implementation uses thesha256()
andkeccak256()
functions provided in theBytes
type implementation.This PR moves the assembly block that does the hashing into the
Hasher
. This allows for the homogenous syntax of hashing any type and moves all hashing into thehash.sw
file.This PR also implements the
Hash
trait for theBytes
andString
types.Before:
After:
Checklist
Breaking*
orNew Feature
labels where relevant.