Accumulate typechecking methods in impl TypeCheckContext
, part 1
#5087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially resolves issue #5050
All methods from
impl Namespace
from the filenamespace.rs
that also takeEngines
as a parameter have been moved intoimpl TypeCheckContext
.I'm splitting the refactoring into several PRs to solicit early feedback, make review process a bit easier and potentially create fewer merge conflicts.
List of changes:
ctx.namespace.find_method_for_type
->ctx.find_method_for_type
ctx.namespace.find_constant_for_type
->ctx.find_constant_for_type
ctx.namespace.get_items_for_type_and_trait_name
->ctx.get_items_for_type_and_trait_name
ctx.namespace.insert_trait_implementation
->ctx.insert_trait_implementation
ctx.namespace.variant_import
->ctx.variant_import
ctx.namespace.item_import
->ctx.item_import
ctx.namespace.self_import
->ctx.self_import
ctx.namespace.variant_star_import
->ctx.variant_star_import
ctx.namespace.star_import
->ctx.star_import
ctx.namespace.find_items_for_type
->ctx.find_items_for_type
ctx.namespace.resolve_call_path_with_visibility_check
->ctx.resolve_call_path_with_visibility_check
ctx.namespace.resolve_type_with_self
->ctx.resolve_type_with_self
(and the previous specialized version inctx
removed)ctx.namespace.resolve_type_without_self
->ctx.resolve_type_without_self
(and the previous specialized version inctx
removed)Checklist
Breaking*
orNew Feature
labels where relevant.