Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split compilation and traversal stages #5074

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Split compilation and traversal stages #5074

merged 4 commits into from
Sep 1, 2023

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Sep 1, 2023 •
edited
Loading

Description

This PR splits the compilation and traversal stages into separate functions. This allows us to benchmark each part separately from the other.

related to #5001

The current measurements are below.

Request Type/Method Time
compile 2.4822s
traverse 422ms

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty changed the title Josh/split stages Split compilation and traversal stages Sep 1, 2023
@JoshuaBatty JoshuaBatty self-assigned this Sep 1, 2023
@JoshuaBatty JoshuaBatty requested review from a team September 1, 2023 00:31
@JoshuaBatty JoshuaBatty added the language server LSP server label Sep 1, 2023
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) September 1, 2023 00:41
@JoshuaBatty JoshuaBatty requested a review from a team September 1, 2023 10:55
@JoshuaBatty JoshuaBatty merged commit 7497fb6 into master Sep 1, 2023
31 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/split_stages branch September 1, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@tritao tritao tritao approved these changes

Assignees

@JoshuaBatty JoshuaBatty

Labels
language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaBatty @tritao @sdankel