Fixes assert_eq always passing for U256 #5054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue was occurring because
get_items_for_type_and_trait_name
was comparing an absolute call path to an external relative call path, when the second should also be absolute.compile_fn
now checks if method is trait dummy.These changes should avoid the silent failures where a dummy method is used,
instead of the proper implementation.
Closes #4989
Checklist
Breaking*
orNew Feature
labels where relevant.