Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostics in multi file projects #5030

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 24, 2023

Description

Closes #5027

Now instead of caching the Diagnostics object, we cache a mapping of file path -> Diagnostics

When we publish diagnostics, we only publishing the diagnostics for the given URI, not for the entire project. I added a test where there are no diagnostics in the main.sw file, but a bunch of diagnostics in the other files in the project.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review August 24, 2023 23:52
@sdankel sdankel requested a review from a team August 24, 2023 23:52
@JoshuaBatty JoshuaBatty added the language server LSP server label Aug 25, 2023
@JoshuaBatty
Copy link
Member

JoshuaBatty commented Aug 25, 2023

Just tested this locally, wow I can't believe how bad it was! We need to get this in the beta-4 release for sure. Thanks for spotting this error! So much nicer now.

@JoshuaBatty JoshuaBatty requested a review from a team August 25, 2023 00:26
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work

@JoshuaBatty JoshuaBatty requested review from a team August 25, 2023 00:47
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) August 25, 2023 01:50
@JoshuaBatty JoshuaBatty merged commit bca210e into master Aug 25, 2023
30 checks passed
@JoshuaBatty JoshuaBatty deleted the sophie/diagnosticsMultiFile branch August 25, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP shows diagnostics for libraries in the wrong file
3 participants