-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fmt panic for const inside trait and abi #5009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eureka-cpu
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve once CI checks pass, nice one @sdankel !
sdankel
changed the title
Fix fmt panic for const inside trait
Fix fmt panic for const inside trait and abi
Aug 24, 2023
sdankel
commented
Aug 24, 2023
tritao
reviewed
Aug 24, 2023
tritao
approved these changes
Aug 24, 2023
JoshuaBatty
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5008
The panic happened because the formatter was adding two
;
s after a constant declaration inside of a trait. It happened for ABI too, so it's fixed for both with tests.I'm working toward the goal of making it so the formatter never panics, even for sway files that do not compile.
I made it so, when a sway file does not compile, it does not cause the formatter to panic. Now it prints an error message.
I'm checking in this simple bash script that runs the formatter against every sway project in the repo. Fixing these bugs brought the # of panics from ~35 down to 15.
I verified that the CI step that checks the formatting of sway docs is still working.
Checklist
Breaking*
orNew Feature
labels where relevant.