-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appendix A: Keywords to Sway book #4992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have not checked all the links to ensure that they point to where they ought to
- Unfortunately, I really do not have the bandwidth to make individual suggestions for each definition but I would re-write most / almost all of the definitions to be more accurate / concise. Most aren't bad but ought to be updated imo
Appreciate the review, all the links I found should check out! As far as the definitions I tried to make it as boiled down as possible, using rust's appendix as reference (https://doc.rust-lang.org/book/appendix-01-keywords.html). However, I can change any you feel need to be updated. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @andrewvious really great work, checked all the links and they're correct.
I've requested just one change and I think this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Can you update the links to the sway book so that they are all relative instead of absolute urls? This way the versions won't need to be updated.
I went ahead and set all the urls to the relative path in the book, but lost some precision the links had. Let me know if this works, or if there is a better way of doing it! |
The reference seems to always point to a page instead of a specific heading. I don't recall if I did that because I couldn't link it precisely or because each section was meant to be a small page. If the page is too full then changing that page will inevitably lead to headings being changed and links being broken so it's better to structure content per page in a digestible manner. I haven't tested the links but I wonder if we should be mixing the book and reference. The reference was meant to entirely replace the book, and hopefully it will before mainnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly glancing through CI the linter fails because the links start with /docs
instead of ./docs
(I assume, haven't checked)
Thanks! I have one more nit: can you move this page into the existing Sway Reference section and remove the Appendix section? |
Would you mind further elaborating where inside the reference section you would prefer this to be moved to? |
Move entire section from the book into the reference at the bottom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work
Description
closes #4932
Checklist
Breaking*
orNew Feature
labels where relevant.