-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runnables code lens in multi-file sway projects #4984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdankel
changed the title
Fix runnables code lens in multi-file projects
Fix runnables code lens in multi-file sway projects
Aug 19, 2023
JoshuaBatty
reviewed
Aug 21, 2023
JoshuaBatty
reviewed
Aug 21, 2023
JoshuaBatty
reviewed
Aug 21, 2023
JoshuaBatty
reviewed
Aug 21, 2023
Nice optimisation! just some small nits. |
JoshuaBatty
reviewed
Aug 21, 2023
## Description Migrates this test to use the new approach that was recently introduced. Should fix CI errors. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
JoshuaBatty
approved these changes
Aug 23, 2023
eureka-cpu
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4983
The issue was that we were returning all of the runnables for the workspace, rather than just the file. We were also calling
get_range_from_span
for every runnable at request time, which @JoshuaBatty discovered is very costly.Checklist
Breaking*
orNew Feature
labels where relevant.