-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lsp_types
directly in sway-lsp
tests instead of simulating a client with tower-lsp
#4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
force-pushed
the
josh/lsp_testing_framework
branch
from
August 21, 2023 00:55
656092d
to
315746d
Compare
tritao
approved these changes
Aug 21, 2023
sdankel
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have this decoupling! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the mock client <> server interaction to test the language server features in favour of using
lsp_types
directly. There are a few places likedid_change
where we are still using the exisiting framework, this is because we still rely on thetower-lsp
event loop to synchronise notification messages. This will be tackled with the custom event loop work. Should be easy to just update the remaining tests here within that PR. I've also kept the publish diagnostics test the same as we still rely on theClient
fromtower-lsp
for that functionality.There were also a few tests here that were unnecessary. Namely,
initialized
initializes_only_once
shutdown
refuses_requests_after_shutdown
. These tests are actually duplicated fromtower-lsp
itself, so there is really no reason we need to run them again insway-lsp
.working towards #4958
Checklist
Breaking*
orNew Feature
labels where relevant.