feat: deprecate --unsigned
flag in favor of --default-signer
for forc-deploy/run
#4957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates
--unsigned
flag in favor of--default-signer
. The reasoning is the following:The reason
forc-deploy
was offering--unsigned
flag was enabling users to create deployment transactions agains their local node without going through wallet funding steps, an ease of development & testing. There are some accounts funded by fuel-core by default, we can still offer the same seamless deployment to local node by signing them with one of these default accounts. So after this PR we can use the following command to deploy to a local node without going through any manual signing/funding steps:We are still keeping the
--unsigned
flag to make sure anyone depending on it does not break out of no where but we print an explicit warning alongside it. Basically it is now aliased to--default-signer
by default and should be removed completely after giving downstream enough time to settle.