Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u256 const eval and constant optimizations #4949

Merged
merged 5 commits into from
Aug 23, 2023
Merged

u256 const eval and constant optimizations #4949

merged 5 commits into from
Aug 23, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 14, 2023 •
edited
Loading

Description

This PR is part of #4794. It implements const eval and optimizations for u256.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj mentioned this pull request Aug 14, 2023
Closed
19 tasks
@xunilrj xunilrj marked this pull request as ready for review August 15, 2023 09:30
@xunilrj xunilrj self-assigned this Aug 15, 2023
@xunilrj xunilrj requested a review from a team August 15, 2023 09:30
@xunilrj xunilrj changed the title u256 constant optimizations u256 const eval and constant optimizations Aug 15, 2023
@xunilrj xunilrj force-pushed the xunilrj/u256-constants-optimization branch from afde761 to eb4c0c4 Compare August 17, 2023 13:13
@IGI-111 IGI-111 requested a review from a team August 17, 2023 18:09
@xunilrj xunilrj requested a review from IGI-111 August 18, 2023 08:19
@xunilrj xunilrj force-pushed the xunilrj/u256-constants-optimization branch 2 times, most recently from b74a304 to aa7f996 Compare August 21, 2023 09:37
@xunilrj xunilrj requested a review from a team August 21, 2023 11:01
@xunilrj xunilrj force-pushed the xunilrj/u256-constants-optimization branch from aa7f996 to 6e75891 Compare August 22, 2023 08:20
@xunilrj xunilrj merged commit f225c0c into master Aug 23, 2023
30 checks passed
@xunilrj xunilrj deleted the xunilrj/u256-constants-optimization branch August 23, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xunilrj @JoshuaBatty @IGI-111