Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-ci: temporarily disable check-links for exact version usages in docs #4948

Merged
merged 1 commit into from
Aug 14, 2023
Merged

docs-ci: temporarily disable check-links for exact version usages in docs #4948

merged 1 commit into from
Aug 14, 2023

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Aug 14, 2023 •
edited
Loading

Description

related to #4946.

Directly using /latest instead of exact versioning does not work for some reason. To unblock bump PRs (one waiting, #4945) this PR disables link checks at links which uses exact latest versions. We should find a way to point to latest without using an exact version.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@kayagokalp kayagokalp self-assigned this Aug 14, 2023
@kayagokalp kayagokalp marked this pull request as ready for review August 14, 2023 11:46
@kayagokalp kayagokalp enabled auto-merge (squash) August 14, 2023 11:46
@kayagokalp kayagokalp requested review from sarahschwartz and a team August 14, 2023 11:46
@kayagokalp kayagokalp mentioned this pull request Aug 14, 2023
Open
@IGI-111 IGI-111 requested a review from a team August 14, 2023 11:49
@kayagokalp kayagokalp merged commit 254e50e into master Aug 14, 2023
27 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/4946 branch August 14, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

@sarahschwartz sarahschwartz Awaiting requested review from sarahschwartz

Assignees

@kayagokalp kayagokalp

Labels
ci documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kayagokalp @tritao @IGI-111