-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser recovery for let statements #4925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunilrj
force-pushed
the
xunilrj/parser-recovery-let
branch
from
August 11, 2023 10:04
4f2829c
to
cae82cc
Compare
IGI-111
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the base structure is sound but the way the error handling is propagated needs to be rewritten, you shouldn't ever need to clear errors and warnings.
IGI-111
approved these changes
Aug 15, 2023
tritao
approved these changes
Aug 15, 2023
tritao
reviewed
Aug 15, 2023
tritao
reviewed
Aug 15, 2023
xunilrj
force-pushed
the
xunilrj/parser-recovery-let
branch
from
August 15, 2023 19:14
be892bb
to
247aa43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #4911.
It primarily does two things:
1 - Extend a lot of functions that return
CompileError
to returnVec<CompileError>
allowing multiple errors to return;2 - Implements the concept of parser recovery.
This happens when using the function
guarded_parse_with_recovery
, exemplified below. When the guard fails, this function returnOk(None)
; when it succeeds it returnsOk(item)
. The exciting part is when the parsing fails.It returns an instance of
Recoverer
which contains a reference to the original parser before any tentative parser was done and the forked as left by the parsing function.The idea is that it is the caller's responsibility to put the forked parser in a "good position". For that, it offers some helpers function and access to the forked parser.
To avoid boilerplate code one recovery strategy is already implemented
recover_at_next_line_with_fallback_error
which consumes everything at the forked parser's current line and emits an error if none were generated by the tentative parser.With this, we have the LSP not "dying" when a strange error happens. The errors themselves are not brilliant, but they will be improved in other PRs.
Checklist
Breaking*
orNew Feature
labels where relevant.