Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u256 not operator #4924

Merged
merged 5 commits into from
Aug 8, 2023
Merged

u256 not operator #4924

merged 5 commits into from
Aug 8, 2023

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 7, 2023

Description

This PR is part of #4794. It implements the not operator for u256 and allows values bigger than u64.

To support that it implements U256 inside sway-types. For now, it is a bare minimum wrapper around BigUint. We may use fuel macro in the future, which implements all necessary functions.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj mentioned this pull request Aug 7, 2023
19 tasks
@xunilrj xunilrj marked this pull request as ready for review August 7, 2023 14:36
@xunilrj xunilrj requested a review from a team August 7, 2023 14:36
@IGI-111 IGI-111 requested a review from a team August 8, 2023 10:16
@xunilrj xunilrj merged commit 974bc2f into master Aug 8, 2023
@xunilrj xunilrj deleted the xunilrj/u256-not-operator branch August 8, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants