Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor did_* lsp notifications to log errors in server module #4894

Merged
merged 5 commits into from
Aug 1, 2023
Merged

refactor did_* lsp notifications to log errors in server module #4894

merged 5 commits into from
Aug 1, 2023

Conversation

JoshuaBatty
Copy link
Member

Description

This PR just bubbles up any errors to be logged in the server module rather that in the did_change did_open or did_save methods. Also made the resync temp folder with workspace logic it's own method on sync.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty self-assigned this Aug 1, 2023
@JoshuaBatty JoshuaBatty requested review from a team August 1, 2023 01:01
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) August 1, 2023 01:08
sdankel
sdankel approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoshuaBatty JoshuaBatty requested a review from a team August 1, 2023 02:04
@JoshuaBatty JoshuaBatty merged commit 0341a7e into master Aug 1, 2023
eureka-cpu
eureka-cpu approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK :shipit:

@JoshuaBatty JoshuaBatty deleted the josh/refactor_notifications branch August 1, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eureka-cpu eureka-cpu eureka-cpu approved these changes

@sdankel sdankel sdankel approved these changes

Assignees

@JoshuaBatty JoshuaBatty

Labels
code quality language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaBatty @sdankel @eureka-cpu