Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky lsp test: publish_diagnostics_dead_code_warning #4856

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix flaky lsp test: publish_diagnostics_dead_code_warning #4856

merged 2 commits into from
Jul 25, 2023

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Jul 24, 2023 •
edited
Loading

Description

Temporarily removing the publish_diagnostics_dead_code_warning test so it unblocks our CI until I can work out how to fix it.

Managed to fix the test while this was open. We now no longer timeout waiting for the requests and instead await until they are ready.

Closes #4855

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty self-assigned this Jul 24, 2023
@JoshuaBatty JoshuaBatty added bug Something isn't working ci labels Jul 24, 2023
@JoshuaBatty JoshuaBatty requested a review from a team July 24, 2023 22:29
tritao
tritao previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@tritao tritao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would #[ignore] also work here?

@JoshuaBatty
Copy link
Member Author

Would #[ignore] also work here?

Yeah that's cleaner. Will update. thanks

@JoshuaBatty JoshuaBatty requested review from tritao and a team July 24, 2023 22:36
tritao
tritao previously approved these changes Jul 24, 2023
View reviewed changes
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) July 24, 2023 23:04
@JoshuaBatty JoshuaBatty changed the title temp remove publish_diagnostics_dead_code_warning test Fix flaky lsp test: publish_diagnostics_dead_code_warning Jul 25, 2023
@JoshuaBatty JoshuaBatty requested review from tritao and a team July 25, 2023 00:28
@JoshuaBatty JoshuaBatty merged commit 5670dea into master Jul 25, 2023
@JoshuaBatty JoshuaBatty deleted the josh/diag_test_remove branch July 25, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@anton-trunov anton-trunov anton-trunov approved these changes

@tritao tritao Awaiting requested review from tritao

Assignees

@JoshuaBatty JoshuaBatty

Labels
bug Something isn't working ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky lsp test: publish_diagnostics_dead_code_warning
4 participants
@JoshuaBatty @tritao @anton-trunov @kayagokalp