Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on external library for Ownership example #4832

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jul 19, 2023

Description

It was noted that in the case of a breaking change to the std-lib, the external Ownership library would need to be updated, which depended on the std-lib creating a circular dependency.

The external library has been removed from the example and a skeleton of its implementation has been added with a link to the actual implementation.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added The Sway Book Everything to do with the Sway Book P: critical Should be looked at before anything else labels Jul 19, 2023
@bitzoic bitzoic self-assigned this Jul 19, 2023
@IGI-111 IGI-111 enabled auto-merge (squash) July 19, 2023 14:45
@IGI-111 IGI-111 requested a review from a team July 19, 2023 14:48
@IGI-111 IGI-111 merged commit 5d27e25 into master Jul 19, 2023
@IGI-111 IGI-111 deleted the bitzoic-ownership-docs-skeleton branch July 19, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: critical Should be looked at before anything else The Sway Book Everything to do with the Sway Book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants