Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for LSP with different IDEs #4801

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Add documentation for LSP with different IDEs #4801

merged 4 commits into from
Jul 17, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jul 14, 2023

Description

Closes #4276

Screenshots:

Screenshot 2023-07-14 at 2 10 47 PM
Screenshot 2023-07-14 at 2 10 57 PM
Screenshot 2023-07-14 at 2 11 02 PM
Screenshot 2023-07-14 at 2 11 12 PM

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review July 14, 2023 22:26
@sdankel sdankel requested a review from a team July 14, 2023 22:26
@JoshuaBatty JoshuaBatty requested a review from a team July 17, 2023 00:01
JoshuaBatty
JoshuaBatty approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@JoshuaBatty JoshuaBatty requested a review from a team July 17, 2023 02:08
kayagokalp
kayagokalp approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sdankel sdankel enabled auto-merge (squash) July 17, 2023 19:12
@sdankel sdankel merged commit 6b50f9d into master Jul 17, 2023
@sdankel sdankel deleted the sophie/lsp-docs branch July 17, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@sdankel sdankel

Labels
documentation language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation about setting up IDEs with sway language support
3 participants
@sdankel @JoshuaBatty @kayagokalp