-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperABIs for ABIs #4272
Merged
Merged
SuperABIs for ABIs #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-trunov
added
enhancement
New feature or request
language feature
Core language features visible to end users
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
labels
Mar 13, 2023
anton-trunov
force-pushed
the
anton-trunov/superabis-for-abis
branch
from
March 27, 2023 13:52
496f2ec
to
77b6d25
Compare
anton-trunov
force-pushed
the
anton-trunov/superabis-for-abis
branch
from
July 19, 2023 08:38
5e4304d
to
a9067c4
Compare
anton-trunov
added
the
ABI
Everything to do the ABI, especially the JSON representation
label
Jul 19, 2023
it was causing incorrect DCA warnings
IGI-111
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JoshuaBatty
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ABI
Everything to do the ABI, especially the JSON representation
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
enhancement
New feature or request
language feature
Core language features visible to end users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4049
Description
Please see the linked issue.
Tasks
Take ABI constants into account, including shadowing issues(decided to postpone this, see the issue ABIs do not inherit constants from their superABIs #4869)Checklist
Breaking*
orNew Feature
labels where relevant.