Fix DCA for generic functions #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added a commit
that referenced
this pull request
Jan 27, 2023
Replaces `IdentUnique` usage with `(Ident, TyFunctionSig)`. Borrowed TyFunctionSig from #3878
tritao
force-pushed
the
dca-generics
branch
4 times, most recently
from
f93b455
to
3fddf4a
Compare
tritao
added
compiler
IGI-111
reviewed
Feb 6, 2023
IGI-111
reviewed
Feb 6, 2023
sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs
Outdated
Show resolved
Hide resolved
vaivaswatha
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3671.
There were a bunch of different fixes necessary to fix this one, which are separated into individual commits to make it easier to review. The main gist is that the DCA now keeps track of functions by their signature instead of just their name and when encountering monomorphized functions in the DCA engine, we now look for their counterpart fully generic version and link the two together.
Previously:
Now: