Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forc run simulate txs #1845

Merged
merged 3 commits into from
Jun 16, 2022
Merged

forc run simulate txs #1845

merged 3 commits into from
Jun 16, 2022

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Jun 3, 2022

No description provided.

@ra0x3 ra0x3 added the forc label Jun 3, 2022
@ra0x3 ra0x3 self-assigned this Jun 3, 2022
@ra0x3 ra0x3 marked this pull request as draft June 3, 2022 18:59
@ra0x3 ra0x3 linked an issue Jun 3, 2022 that may be closed by this pull request
Allow simulating txs with forc run #1652
Closed
@ra0x3
Copy link
Contributor Author

ra0x3 commented Jun 3, 2022

@adlerjohn

  • Not really sure how to test this
  • Would I just forc init --contract a new project and forc run --simulate-tx ?
    • Getting a Error: Response errors; Unknown argument "utxoValidation" on field "dryRun" of type "Mutation". error when taking this route
  • Wondering basically if I have to do anything special test this and ensure it's working

@adlerjohn
Copy link
Contributor

That's how you would test it, yes. I think that error is popping up because your version of fuel-core is outdated.

@ra0x3 ra0x3 marked this pull request as ready for review June 13, 2022 16:30
mitchmindtree
mitchmindtree reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one small suggestion.

forc/src/ops/forc_run.rs Outdated Show resolved Hide resolved
@adlerjohn adlerjohn mentioned this pull request Jun 14, 2022
Open
@ra0x3 ra0x3 requested a review from mitchmindtree June 15, 2022 23:00
mitchmindtree
mitchmindtree approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@mitchmindtree mitchmindtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@adlerjohn adlerjohn enabled auto-merge (squash) June 16, 2022 01:50
@adlerjohn adlerjohn merged commit 00a9224 into master Jun 16, 2022
@adlerjohn adlerjohn deleted the rashad/1652-forc-run-sim-tx branch June 16, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

Assignees

@ra0x3 ra0x3

Labels
forc
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow simulating txs with forc run
4 participants
@ra0x3 @adlerjohn @JoshuaBatty @mitchmindtree