Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent version of fuel-core in debugger CI tests #5393

Closed
sdankel opened this issue Dec 14, 2023 · 0 comments · Fixed by #5486
Closed

Use consistent version of fuel-core in debugger CI tests #5393

sdankel opened this issue Dec 14, 2023 · 0 comments · Fixed by #5486
Labels
ci forc-debug Everything related to forc-debug good first issue Good for newcomers

Comments

@sdankel
Copy link
Member

sdankel commented Dec 14, 2023 

          Seeing that we have multiple fuel-core versions laying around in the yaml file, maybe we should take this from an env variable, it might be hard to update separate locations everytime forc starts supporting a new fuel-core version.

Originally posted by @kayagokalp in #5390 (comment)
@sdankel sdankel added ci debugger forc-debug Everything related to forc-debug labels Dec 14, 2023
@sdankel sdankel assigned sdankel and unassigned sdankel Dec 14, 2023
@sdankel sdankel added good first issue Good for newcomers and removed debugger labels Dec 14, 2023
This was referenced Jan 15, 2024
Closed
Merged
tritao pushed a commit that referenced this issue Jan 19, 2024
@levisyin
ci: get fuel-core version from an env variable (#5486)
546bd99 
## Description
Closes #5393 

Use consistent version of fuel-core in debugger CI tests from an env
variable `FUEL_CORE_VERSION`

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci forc-debug Everything related to forc-debug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@sdankel