Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tests for the new ecr functionality #5220

Closed
Braqzen opened this issue Oct 23, 2023 · 0 comments · Fixed by #5233
Closed

Additional tests for the new ecr functionality #5220

Braqzen opened this issue Oct 23, 2023 · 0 comments · Fixed by #5233
Assignees
@bitzoic
Labels
lib: std Standard library testing General testing

Comments

@Braqzen
Copy link
Contributor

Braqzen commented Oct 23, 2023

#5133 has introduced some new functions. Looking through the tests there are a number of missing Sway tests.

  • ec_recover has no positive or negative test cases - likely because they exist elsewhere, perhaps in the sdk harness
  • ec_recover_r1 has no negative case
  • test_ec_recover_address_r1 has no negative case
  • ed_verify has no negative case

There are also some minor doc typos

Note that we may be unable to make the recovery panic ourselves and thus return an error but perhaps we may be able to return an incorrect recovery value.
@Braqzen Braqzen added lib: std Standard library testing General testing labels Oct 23, 2023
@bitzoic bitzoic linked a pull request Oct 27, 2023 that will close this issue
Add revert cases for new ecr functionality #5233
Merged
7 tasks
@bitzoic bitzoic mentioned this issue Oct 27, 2023
Merged
7 tasks
@bitzoic bitzoic self-assigned this Oct 30, 2023
bitzoic added a commit that referenced this issue Oct 31, 2023
@bitzoic
Add revert cases for new ecr functionality (#5233)
5c2304c 
## Description

Only success test cases exist for the newly added `ed19` and `ecr1`
opcodes exist. Revert cases have been added to the inline tests.

Closes #5220 

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: bitzoic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitzoic bitzoic

Labels
lib: std Standard library testing General testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add revert cases for new ecr functionality FuelLabs/sway
2 participants
@bitzoic @Braqzen