-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong DCA warning while using struct method defined in impl self. #4328
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
DCA
Everything to do with Dead Code Analysis
Comments
esdrubal
added
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
DCA
Everything to do with Dead Code Analysis
labels
Mar 23, 2023
IGI-111
pushed a commit
that referenced
this issue
Apr 24, 2023
## Description Adds support for aliases in DCA. Fixes #4328 where a DCA warning was emmited while using struct method defined in an impl self. Closes #4283 Closes #4328 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: Sophie Dankel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
DCA
Everything to do with Dead Code Analysis
While compiling the following:
We are getting this DCA warnings:
In rust there are no warnings emitted, as shown in this playground.
The current DCA graph to the example is as follows:
The text was updated successfully, but these errors were encountered: