Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self keyword has incorrect hover formatting #3966

Closed
JoshuaBatty opened this issue Feb 2, 2023 · 1 comment
Closed

self keyword has incorrect hover formatting #3966

JoshuaBatty opened this issue Feb 2, 2023 · 1 comment
Assignees
@sdankel
Labels
bug Something isn't working language server LSP server

Comments

@JoshuaBatty
Copy link
Member

From @sdankel in #3792

I see the hover for self when it's a function parameter, but not when it's used inside of a function block (e.g. self.bar)

image
@JoshuaBatty JoshuaBatty added bug Something isn't working language server LSP server labels Feb 2, 2023
@JoshuaBatty JoshuaBatty mentioned this issue Feb 2, 2023
Merged
@sdankel sdankel self-assigned this Apr 19, 2023
@sdankel sdankel mentioned this issue Apr 19, 2023
Merged
7 tasks
sdankel added a commit that referenced this issue Apr 19, 2023
@sdankel
Fix hover docs for self and boolean keywords (#4469)
49ec0bc 
## Description

Closes #3967
#3966


![image](https://user-images.githubusercontent.com/47993817/233210418-1a641c16-9448-4ae9-bb67-8e2ef09effcc.png)


![image](https://user-images.githubusercontent.com/47993817/233210467-77f6710e-5447-4910-9181-8d80baafbfc0.png)

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@JoshuaBatty
Copy link
Member Author

JoshuaBatty commented Apr 19, 2023 •
edited
Loading

fixed in #4469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdankel sdankel

Labels
bug Something isn't working language server LSP server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaBatty @sdankel