Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: limit TX pagination number for getTransactionsSummaries #3400

Merged

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Nov 15, 2024

Release notes

In this release, we:

  • Limit pagination number for getTransactionsSummaries to 60

Breaking Changes

The pagination number for getTransactionsSummaries is limited to 60 now

// before
const { transactions } = await getTransactionsSummaries({
  provider,
  filters: {
    owner: account.address.toB256(),
    first: 200,
  },
});
// after
const { transactions } = await getTransactionsSummaries({
  provider,
  filters: {
    owner: account.address.toB256(),
    first: 60, // Limit is 60 now. A higher value will result in an error
  },
});

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the chore Issue is a chore label Nov 15, 2024
@Torres-ssf Torres-ssf self-assigned this Nov 15, 2024
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:19am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-docs-api ⬜️ Ignored (Inspect) Nov 15, 2024 0:19am

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #3400 will not alter performance

Comparing st/chore/limit-pagination-number-getTransactionsSummaries (0ad5fd6) with master (bdf0ebe)

Summary

✅ 18 untouched benchmarks

nedsalk
nedsalk previously approved these changes Nov 15, 2024
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes Nov 15, 2024
@nedsalk nedsalk self-requested a review November 15, 2024 12:04
nedsalk
nedsalk previously approved these changes Nov 15, 2024
arboleya
arboleya previously approved these changes Nov 15, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
64.19%(-0.01%) 69.65%(+0%) 72.99%(+0%) 64.63%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.02%
(-0.89%)
57.21%
(-4.89%)
70.96%
(-0.31%)
68.73%
(-0.88%)
✨ packages/account/src/providers/utils/validate-pagination-args.ts 100%
(+100%)
100%
(+100%)
100%
(+100%)
100%
(+100%)

@Torres-ssf Torres-ssf merged commit efdc721 into master Nov 15, 2024
25 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/limit-pagination-number-getTransactionsSummaries branch November 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants