-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typegen and storage slots integration #3396
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9fc3047
to
bd8f764
Compare
CodSpeed Performance ReportMerging #3396 will improve performances by 16.5%Comparing Summary
Benchmarks breakdown
|
This reverts commit 7cb0db6.
139be6d
to
e7d6196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @nedsalk 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to request changes with the following comment.
Coverage Report:
Changed Files:
|
Summary
This PR fixes integration of typegen'd storage slots with the
ContractFactory.deployAsCreateTx
andContractFactory.deployAsBlobTx
methods by making it possible to specifydeployOptions
in theContractFactory
constructor, passing the storage slots via the constructor in typegen'd factories, and using them in those methods.This approach also enables us to remove the override of the
deploy
method in typegen.Checklist